Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs.urlevent callback parameters are now lowercase #3691

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

cmsj
Copy link
Member

@cmsj cmsj commented Sep 19, 2024

Closes #3686

@cmsj cmsj added the pr-fix Pull Request implementing a bug fix label Sep 19, 2024
@cmsj cmsj self-assigned this Sep 19, 2024
@cmsj cmsj added this to the 1.0.1 milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (08cb813) to head (b621ad5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
- Coverage   27.67%   27.36%   -0.32%     
==========================================
  Files         191      191              
  Lines       43532    51399    +7867     
==========================================
+ Hits        12049    14065    +2016     
- Misses      31483    37334    +5851     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hs.urlevent incorrectly treats scheme in case sensitive manner
1 participant