Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Properly track eventSubmitted, updates to Slack message around PR deploys #2343

Merged
merged 28 commits into from
Aug 30, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Aug 30, 2024

Description of change

We need to capture the "eventSubmitted" variable in the data of a Training Report when the owner submits it. The "complete event" functionality depends on it. It seems to have been removed as part of a bug squash in the days leading up to the TR release.

This PR also includes code to further customize the slack message deployments.

How to test

Impersonating the user in this slack thread, confirm that you can submit and then complete the event in question

Alternately, confirm "eventSubmitted" is present in the request body when submitting a training report. A unit test has been added to validate this specific field.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod changed the title [Prod] Properly track "eventSubmitted," updates to Slack message around PR deploys [Prod] Properly track eventSubmitted, updates to Slack message around PR deploys Aug 30, 2024
@thewatermethod thewatermethod marked this pull request as ready for review August 30, 2024 19:34
@kryswisnaskas
Copy link
Collaborator

Merging since this PR is time sensitive.

@kryswisnaskas kryswisnaskas merged commit 857b9b3 into production Aug 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants