dungeon drop implementation #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingRainbow44
requested changes
Jun 17, 2023
src/main/java/emu/grasscutter/game/dungeons/DungeonManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>
KingRainbow44
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reward of reliquary dungeons were determined by custom-defined json file in the past, now we can switch to the new drop system to handle it.
The new drop system can provide a more accurate reward.
Please carefully read the Contributing note and Code of conduct before making any pull requests.
Issues fixed by this PR
Type of changes
Checklist: