Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister commands onDisable #74

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

efekurbann
Copy link
Contributor

@efekurbann efekurbann commented Aug 1, 2024

Since TriumphCommands don't automatically unregister commands onDisable, we'll.
This allows users to use PlugMan or ServerUtils, still not recommended tho

This allows users to use PlugMan or ServerUtils, still not recommended tho
@poyrazinan poyrazinan self-requested a review August 7, 2024 18:17
Copy link
Member

@poyrazinan poyrazinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Need to create another class file for this unregister method. Main class cannot usable for this kind of code blocks.
  • Also required description to code methods. (params, author and desc.)

@poyrazinan poyrazinan assigned poyrazinan and efekurbann and unassigned poyrazinan Aug 7, 2024
@poyrazinan poyrazinan added help wanted Extra attention is needed fixed issues labels Aug 7, 2024
@poyrazinan poyrazinan added this to the b107 milestone Aug 7, 2024
@efekurbann
Copy link
Contributor Author

@poyrazinan, should be all set now. Let me know any more changes are needed.

@poyrazinan poyrazinan self-requested a review August 20, 2024 17:29
Copy link
Member

@poyrazinan poyrazinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@poyrazinan poyrazinan merged commit 75d87dc into Geik-xyz:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issues help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants