Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL Support #22

Merged
merged 11 commits into from
Jul 18, 2023
Merged

Add MySQL Support #22

merged 11 commits into from
Jul 18, 2023

Conversation

amownyy
Copy link
Contributor

@amownyy amownyy commented Jul 17, 2023

Added mysql support.
image

image

image

image

@poyrazinan
Copy link
Member

The code style written is incompatible with the structure of the existing project. I am performing abstraction by using the User object for User and the Farmer object for Farmer. In this system, inheritance is being done from the SQL class based on its SQL type. Instead, could you please provide inheritance suitable for these classes?

poyrazinan and others added 5 commits July 17, 2023 22:16
this commit is the example of inheritance of code style of this project
+ updated abstraction of sql
+ added descriptions to new classes
@poyrazinan poyrazinan added enhancement New feature or request good first issue Good for newcomers update labels Jul 17, 2023
poyrazinan and others added 3 commits July 18, 2023 00:22
+ forces table names to default, now users cannot change table names of plugin
@poyrazinan poyrazinan self-requested a review July 17, 2023 21:46
@poyrazinan poyrazinan changed the base branch from main to develop July 18, 2023 23:11
Copy link
Member

@poyrazinan poyrazinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all checks are ok

@poyrazinan poyrazinan merged commit c56364a into Geik-xyz:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants