Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recipes with enchanted books in them #661

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Fix recipes with enchanted books in them #661

merged 4 commits into from
Jul 5, 2023

Conversation

kuba6000
Copy link
Member

@kuba6000 kuba6000 commented Jul 4, 2023 •
edited
Loading

@kuba6000 kuba6000 requested review from a team July 4, 2023 18:28
Cleptomania
Cleptomania approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@Cleptomania Cleptomania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, definitely a cleaner way to handle the NBT data on the enchanted books. Tested the recipes in game and they all seem to be working.

@Dream-Master Dream-Master merged commit 293cd5d into master Jul 5, 2023
1 check passed
@Dream-Master Dream-Master deleted the fix-recipes branch July 5, 2023 16:45
@wlhlm wlhlm mentioned this pull request Jul 20, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cleptomania Cleptomania Cleptomania approved these changes

@OneEyeMaker OneEyeMaker OneEyeMaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enchanted Lootbag Not Being Able To Be Crafted
4 participants
@kuba6000 @Cleptomania @OneEyeMaker @Dream-Master