Implement nested formatting tags #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it wouldn't work properly anyway without more extensive code changes
Steelux8
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement nested formatting tags, and also add tags for text formatting: bold, italic, underline, strikethrough, obfuscated.
This lets us do things like:
and have it all work as expected.
This PR also changes the semantics of the
[url]tag: instead of being able to specify alternate anchor text for the URL using atext=param, now the link itself can be specified using alink=param, in which case the text inside the[url]tag is used as the anchor text. This change allows applying formatting to the anchor text. I searched the quest database, and didn't find any current usages of thetext=param, so I think that this is a safe change, but it's possible that I missed something.I've done some basic testing of the new
[url]handling, and everything seems to work, except when there is an[img]tag, in which case the hot zones for all[url]tags beyond the[img]tag are placed incorrectly. I checked master and it's broken in the same way, so I think this PR neither fixes nor worsens this issue. I'll file a separate issue for fixing[img]and[url]tomorrow.