Add Quest Bookmarking

[Caedis]

Preview in #mod-dev channel:

https://discord.com/channels/181078474394566657/603348502637969419/1192604755952947291

[Glease]

1. save load is a bit awkward. most of write logic is in QuestInstance but most of read logic is in QuestDatabase. perhaps just move them all to QuestDatabase?
2. as mentioned on discord. this should probably be called favorite bookmark rather than pin.
3. GUI code is always if it works then ship it. we don't check code quality in this area.

[Caedis]

Now the question is, what icon to make to use on the quest instead of the pins

[Caedis]

Took over the bookmark icon and change the quest line icon to a better match

[Caedis]

Hmm, losing bookmarks on a server

[Caedis]

Current issues:

• Bookmarks are not saving when on a server. This is because the quests are handled on the server.

[Lyfts]

Bookmarks are now handled by the client and are unique for each world/server.

[Caedis]

Looks good, i'll take a look at it in game later today

[Caedis]

The order the quests are bookmarked should be kept.

In the screenshot, the IV circuit was the last one I bookmarked.

[Caedis]

Also if a server and a sp world have the same name, the bookmark files will be shared i believe

[Lyfts]

The world name is only used for local worlds for servers their ip+port will be used as file name.

[Caedis]

Cool, didnt even realize that colon were valid in file names

[eigenraven]

Colons are not valid in filenames on Windows: https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions

[Caedis]

Thats what i thought. Worked fine for me on linux

[Caedis]

maybe change it to ip-port

[Lyfts]

I'm already replacing the colon with a dot

[Caedis]

Oh, didnt notice that. That works then

[Lyfts]

Alright bookmarks will now keep their order and I also implemented a simple method to skip iterating over the entire quest list if no bookmarks have changed.

[Caedis]

Perfect, thanks!

...i can't approve it since its my pr lol

[Caedis]

hmmm

[Caedis]

Something is not updating when I change SP worlds
Currently in a sp world with this bookmarked

but, the list is showing the bookmarks from the other world

[Caedis]

I had 2 bookmarks that were shared between the 2 worlds

[Lyfts]

Oh my bad I forgot to reset the flag when loading bookmarks

[Lyfts]

It seems to load correctly now, good catch.

[Caedis]

Perfect

[Dream-Master]

tested works