Skip to content

Commit

Permalink
Switch to PHP_CodeSniffer v3.8.0
Browse files Browse the repository at this point in the history
Unfortunately, `quizlabs/php_codesniffer` is officially abandoned.
A fork has been created at `phpcsstandards/php_codesniffer`.

As such, we now require `PHP_CodeSniffer` v3.8.0 or later. This
version fixes a lot of things and also adds support for PHP 8.3.

The default PHP version for the action is now PHP 8.3. This does
not impact downstream dependencies of this action as long as they
properly configured the version constraints.
  • Loading branch information
tomudding committed Dec 9, 2023
1 parent 2d4cf40 commit b470227
Show file tree
Hide file tree
Showing 4 changed files with 59 additions and 34 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
inputs:
php-version:
description: 'The PHP version to use when running the job'
default: '8.2'
default: '8.3'
required: false
type: 'string'

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# GEWISPHP Coding Standards

The GEWISPHP Coding Standard is a set of [PHP_CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) rules that are applied to all PHP projects of Study Association GEWIS. These standards are heavily based on the [Doctrine Coding Standard](https://github.com/doctrine/coding-standard) and the [Slevomat Coding Standard](https://github.com/slevomat/coding-standard).
The GEWISPHP Coding Standard is a set of [PHP_CodeSniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) rules that are applied to all PHP projects of Study Association GEWIS. These standards are heavily based on the [Doctrine Coding Standard](https://github.com/doctrine/coding-standard) and the [Slevomat Coding Standard](https://github.com/slevomat/coding-standard).
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
"require": {
"php": "^8.2",
"dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
"slevomat/coding-standard": "^8.11",
"squizlabs/php_codesniffer": "^3.7.0"
"slevomat/coding-standard": "^8.14.0",
"squizlabs/php_codesniffer": "^3.8.0"
},
"config": {
"allow-plugins": {
Expand Down
85 changes: 55 additions & 30 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b470227

Please sign in to comment.