Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add egress to banned list of instance names #4533

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

hardillb
Copy link
Contributor

part of FlowFuse/CloudProject#521

Description

This is so we can have a DNS entry for the FF Cloud egress IP address

Related Issue(s)

FlowFuse/CloudProject#521

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

part of FlowFuse/CloudProject#521

This is so we can have a DNS entry for the FF Cloud egress IP
address
@hardillb hardillb self-assigned this Sep 23, 2024
@hardillb
Copy link
Contributor Author

Wondering if this list should be configurable for admins?

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (4e1f5ec) to head (77264d5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4533   +/-   ##
=======================================
  Coverage   78.05%   78.05%           
=======================================
  Files         300      300           
  Lines       14270    14270           
  Branches     3237     3237           
=======================================
  Hits        11138    11138           
  Misses       3132     3132           
Flag Coverage Δ
backend 78.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member

We can make it configurable if/when there's a need to do so

@knolleary knolleary merged commit 45c992a into main Sep 23, 2024
14 checks passed
@knolleary knolleary deleted the add-egress-to-banned-names branch September 23, 2024 09:59
@hardillb
Copy link
Contributor Author

I was more thinking this is a list that applies to all instances, but is pretty specific to FF Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants