Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found race condition in tests #4260

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Found race condition in tests #4260

merged 1 commit into from
Jul 26, 2024

Conversation

hardillb
Copy link
Contributor

Description

Instance start was trying to update the database after the test had finished and the app was closed.

Added await at end of test to wait for instance to read steady state.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (9e000e5) to head (866f71e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4260   +/-   ##
=======================================
  Coverage   78.12%   78.12%           
=======================================
  Files         287      287           
  Lines       13284    13289    +5     
  Branches     2977     2980    +3     
=======================================
+ Hits        10378    10382    +4     
- Misses       2906     2907    +1     
Flag Coverage Δ
backend 78.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit 7a217ad into main Jul 26, 2024
14 checks passed
@knolleary knolleary deleted the test-race-condition branch July 26, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants