-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewire frontend notifications to backend notifications API #4254
Rewire frontend notifications to backend notifications API #4254
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4165-team-invite-notification #4254 +/- ##
==============================================================
Coverage 78.13% 78.13%
==============================================================
Files 292 292
Lines 13403 13403
Branches 3000 3000
==============================================================
Hits 10473 10473
Misses 2930 2930
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Approved, although not merging as to not impact other PRs for the upstream branches |
Thanks @joepavitt - there's one PR left to review, which I'll get done on Monday and then we can merge the whole stack of them. |
Closes #4245
This is the 3rd of three PRs to introduce the new notifications system
Description
This updates the notification frontend to use the new notifications backend API.
Summary of changes:
account
store handling of notifications has been simplified; it now just stores the list of notifications from the api without separating out by type.account
store now handles the user invitations as a separate property