Do not create blank alias names + Update ANTLR #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small update to no longer create empty string Alias names. This would happen when a URL that GoFSH tried to make an alias for ended in a
/, such ashttp://example.org/test/url/. If the URL was justhttp://example.org/, GoFSH already properly handled using the hostname as an alias instead.I also combined this with updating to the same ANTLR version that SUSHI is using,
4.13.1-patch-1, because the update didn't require any code changes. I'm happy to separate these out if that is preferred. I ran the tests, and they still work with the new antlr version, and there were no changes when running this branch on US Core.