Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cran fix 02 #3

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Cran fix 02 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92ac300
now using single quotes
msperlin Aug 22, 2024
880f276
now using single quotes
msperlin Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: eodhdR2
Type: Package
Title: Official R API for Fetching Data from `EODHD`
Title: Official R API for Fetching Data from 'EODHD'
Version: 0.5.0
Authors@R: c(
person(given = c("Marcelo", "S."),
Expand All @@ -12,7 +12,7 @@ Authors@R: c(
email = "support@eodhistoricaldata.com")
)
Maintainer: Marcelo S. Perlin <marceloperlin@gmail.com>
Description: Second and backward-incompatible version of R package `eodhd` <https://eodhd.com/>, extended with a cache and quota system,
Description: Second and backward-incompatible version of R package 'eodhd' <https://eodhd.com/>, extended with a cache and quota system,
also offering functions for cleaning and aggregating the financial data.
License: MIT + file LICENSE
URL: https://github.com/EodHistoricalData/R-Library-for-financial-data-2024
Expand Down
2 changes: 1 addition & 1 deletion cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* tested on [github action](https://github.com/EodHistoricalData/R-Library-for-financial-data-2024/actions), passing for windows (latest), macos (latest) and ubuntu (latest)

### Fixes for CRAN issues
* Fixed issue with api and package names in title and description. Now using single quote, e.g. `EODHD`
* Fixed issue with api and package names in title and description. Now using single quote, e.g. 'EODHD'
* Fixed issue with return value of function `parse_financials()`
* Added new person (copyright holder) and "ctr" tag for myself at DESCRIPTION:

Expand Down