Add pandas requirement, change numpy requirement to 1.22.4 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdmurbach Apparently, Python 3.7 does not work with numpy>1.21, but pandas requires numpy>1.22.4. So maybe the Python version requirement should also be changed to >=3.8? |
mdmurbach
reviewed
Sep 5, 2024
Fix flake8 ignore lines that are causing the linter to fail
Add space causing the linter to fail
Pull Request Test Coverage Report for Build 10823578514Details
💛 - Coveralls |
mdmurbach
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intended to close #305.
Pandas requirement added both to requirements.txt and to setup.py. Changed numpy requirement to 1.22.4 because apparently that is the oldest version still supported by pandas, (see https://pandas.pydata.org/docs/getting_started/install.html#required-dependencies). Perhaps a required version should be specified for pandas, too?