Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework transport to leave re-connect to user #150

Merged
merged 18 commits into from
Feb 25, 2024

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Feb 10, 2024

Avoid handling reconnect inside transports. Signal lost connections via the event system instead to allow user to manage the reconnections.

  • Remove reconnection logic in favor of user handling that
  • Handle a socket shutdown leading to 100% cpu uage
  • Split Connect from Transport construction
  • Split connect() effects and errors from class initializers to allow easier cleanup

RFXtrx/lowlevel.py Show resolved Hide resolved
RFXtrx/lowlevel.py Show resolved Hide resolved
RFXtrx/__init__.py Show resolved Hide resolved
@elupus elupus marked this pull request as ready for review February 24, 2024 09:51
@elupus
Copy link
Collaborator Author

elupus commented Feb 24, 2024

@Danielhiversen any chance you can have a look at this and perhaps make a new release? Should solve most of the disconnect and reconnect issues rfx have had.

@Danielhiversen Danielhiversen merged commit 17c8feb into Danielhiversen:master Feb 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants