Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes duplicate tree view add button for closed Controlled Vocabularies #3350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aseyedia
Copy link

@aseyedia aseyedia commented Sep 24, 2024

References

Fixes #3325

Description

The Controlled Vocabulary tree view was displaying two "Add" buttons, one enabled and one disabled, for closed Controlled Vocabularies.

You can read more here.

Instructions for Reviewers

Minor change. I just removed one of the excess buttons and moved the conditional logic to the [disabled] parameter in the button class.

To test it, try opening up a closed Controlled Vocabulary tree view and observing the "Add" button to make sure it's disabled and that there's only one of them.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@aseyedia aseyedia changed the title Fixes duplicate tree view add button for closed Controlled Vocabularies #3325 Fixes duplicate tree view add button for closed Controlled Vocabularies Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submission form hierarchical tree view has two add buttons, one enabled and the other disabled
1 participant