[Refactor] #199 - 성취 UI 로직 변경 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesuuou
reviewed
Nov 26, 2023
Comment on lines
174
to
177
| switch percentage { | ||
| case 0.0: cell.configure(.none, .week) | ||
| case 1.0: cell.configure(.rateFull, .week) | ||
| default: cell.configure(.rateHalf, .week) |
There was a problem hiding this comment.
percent별로 분기처리는 cell 내부가 아니라 외부에서 하는 이유가 있나여?! cell내부에 있어도 괜찮을 것 같아서요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🫧 작업한 내용
🔫 PR Point
기존의 VC에서 변경했던 cell 속성을 수정했습니다.
📸 스크린샷
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-11-19.at.18.13.31.mp4
📮 관련 이슈