attempt to resolve reported http 500s in ManageEnvelopes and Donation…

…FundEditor (#7164)

# Description & Issue number it closes 
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. -->

Closes #7161 
Closes #7162

cypress/e2e/ui/finance/finance.deposits.spec.js

@@ -1,6 +1,11 @@
 /// <reference types="cypress" />
 
 context("Finance Deposits", () => {
+    it("Envelope Manager", () => {
+        cy.loginAdmin("ManageEnvelopes.php");
+        cy.contains("Envelope Manager");
+    });
+
     it("Create a new Deposit", () => {
         cy.loginAdmin("FindDepositSlip.php");
         cy.contains("Add New Deposit");

src/DonationFundEditor.php

@@ -69,8 +69,8 @@
 } else {
     // Check if we're adding a fund
     if (isset($_POST['AddField'])) {
-        $checkExisting = DonationFundQuery::create()->filterByName($_POST['newFieldName'])->findOne();
-        if (count($checkExisting) > 0) {
+        $checkExisting = DonationFundQuery::create()->findOneByName($_POST['newFieldName']);
+        if ($checkExisting !== null) {
             $bNewNameError = true;
         } else {
             $donation = new DonationFund();

src/ManageEnvelopes.php

@@ -16,7 +16,7 @@
 // Security: User must have finance permission to use this form
 AuthenticationManager::redirectHomeIfFalse(AuthenticationManager::getCurrentUser()->isFinanceEnabled());
 
-$iClassification = null;
+$iClassification = 0;
 if (isset($_POST['Classification'])) {
     $iClassification = (int) InputUtils::legacyFilterInput($_POST['Classification'], 'int');
     $_SESSION['classification'] = $iClassification;