AGVis Update 4.0 #72
Merged
AGVis Update 4.0 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync develop with master
Js file commenting
Fixed Docker issue.
Unittesting
Custom Flask Configurations for AGVis
Update citation info
Updated max zoom
|
There are some valid security issues that codacy brought up, however, these are not being introduced in develop as they were in place before I started working on the project. These concerns should not affect the demo version of agvis, so this merge should be good to go. |
|
Hello Zack, Great work! I might be able to find some time this week to go through this. Regards, |
jinningwang
reviewed
Apr 2, 2024
.github/workflows/test.yml
Outdated
There was a problem hiding this comment.
Two things can be improved.
- Is it okay to name this file as "pythonapp.yml"? It would be consistent across ANDES, AMS, and AGVis then.
- Maybe package publishing can be included here? This is what I do in AMS, every tagged version will trigger PyPI package publishing. https://github.com/CURENT/ams/blob/master/.github/workflows/pythonapp.yml
Let me know if you are interested in the package publishing process, otherwise I can take care of the second one.
There was a problem hiding this comment.
Yes I think it would be good to learn how package with github. I can rename the file as well.
Conform with rest of LTB.
Fixed broken tests. Added agvis selftest functionality
Cleaning up code for codacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there are enough changes for a 4.0 update here. I will update the master branch to 4.0.0 and update documentation after merge.