Skip to content

Commit

Permalink
disable pip publishing
Browse files Browse the repository at this point in the history
After testing, (and realizing something I should have known at the start), pip cannot package non-python files such as .html or .js files. so when publishing and installing this as a package, none of those files are included, and thus, the application is not able to run. It only works on systems that have installed agvis through github. Therefore, pip is pretty much useless with AGVis, and conda would be a better place to handle such publishing tasks.
  • Loading branch information
zmalkmus committed Jun 7, 2024
1 parent 08353b3 commit 6482ed6
Showing 1 changed file with 40 additions and 38 deletions.
78 changes: 40 additions & 38 deletions .github/workflows/pythonapp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,16 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: "3.8"
- name: Install pypa/build and twine
run: python3 -m pip install build twine setuptools_scm
- name: Build a binary wheel and a source tarball
run: python3 -m build
- name: Store the distribution packages
uses: actions/upload-artifact@v4
with:
name: python-package-distributions
path: dist/
# PIP BUILD
# - name: Install pypa/build and twine
# run: python3 -m pip install build twine setuptools_scm
# - name: Build a binary wheel and a source tarball
# run: python3 -m build
# - name: Store the distribution packages
# uses: actions/upload-artifact@v4
# with:
# name: python-package-distributions
# path: dist/

test:
name: Run test suite
Expand All @@ -41,32 +42,33 @@ jobs:
# pip install flake8 # specify flake8 to avoid unknown error
# # stop the build if there are Python syntax errors or undefined names
# flake8 .

publish-to-pypi:
name: Publish Python distribution to PyPI
if: github.ref == 'refs/heads/master' && github.event_name == 'push'
needs:
- build
- test
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.8"
- name: Install twine
run: pip install twine
- name: Download distribution packages
uses: actions/download-artifact@v4
with:
name: python-package-distributions
path: dist/
- name: Check dist/
run: twine check dist/*
- name: Publish Python dist to PyPI
run: twine upload dist/*
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}

# PIP PUBLISH
# publish-to-pypi:
# name: Publish Python distribution to PyPI
# if: github.ref == 'refs/heads/master' && github.event_name == 'push'
# needs:
# - build
# - test
# runs-on: ubuntu-latest
# steps:
# - name: Checkout code
# uses: actions/checkout@v4
# - name: Set up Python
# uses: actions/setup-python@v5
# with:
# python-version: "3.8"
# - name: Install twine
# run: pip install twine
# - name: Download distribution packages
# uses: actions/download-artifact@v4
# with:
# name: python-package-distributions
# path: dist/
# - name: Check dist/
# run: twine check dist/*
# - name: Publish Python dist to PyPI
# run: twine upload dist/*
# env:
# TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}

0 comments on commit 6482ed6

Please sign in to comment.