[KTLN-759] Combine 2 Kotlin State Flows Into a Single State Flow #1093
+107
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
35
to
48
| <dependency> | ||
| <groupId>org.jetbrains.kotlinx</groupId> | ||
| <artifactId>kotlinx-coroutines-test</artifactId> | ||
| <version>1.7.3</version> | ||
| <type>pom</type> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.jetbrains.kotlinx</groupId> | ||
| <artifactId>kotlinx-coroutines-core</artifactId> | ||
| <version>1.8.1</version> | ||
| <type>pom</type> | ||
| <scope>runtime</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Let's extract these versions as properties.
See line 53 for an example of that.
Suggested change
| <dependency> | |
| <groupId>org.jetbrains.kotlinx</groupId> | |
| <artifactId>kotlinx-coroutines-test</artifactId> | |
| <version>1.7.3</version> | |
| <type>pom</type> | |
| </dependency> | |
| <dependency> | |
| <groupId>org.jetbrains.kotlinx</groupId> | |
| <artifactId>kotlinx-coroutines-core</artifactId> | |
| <version>1.8.1</version> | |
| <type>pom</type> | |
| <scope>runtime</scope> | |
| </dependency> | |
| <dependency> | |
| <groupId>org.jetbrains.kotlinx</groupId> | |
| <artifactId>kotlinx-coroutines-test</artifactId> | |
| <version>${kotlinx-coroutines.version}</version> | |
| <type>pom</type> | |
| </dependency> | |
| <dependency> | |
| <groupId>org.jetbrains.kotlinx</groupId> | |
| <artifactId>kotlinx-coroutines-core</artifactId> | |
| <version>${kotlinx-coroutines.version}</version> | |
| <type>pom</type> | |
| <scope>runtime</scope> | |
| </dependency> |
| <groupId>org.jetbrains.kotlinx</groupId> | ||
| <artifactId>kotlinx-coroutines-test</artifactId> | ||
| <version>1.7.3</version> | ||
| <type>pom</type> |
There was a problem hiding this comment.
Why is this a pom type? Wouldn't this just be a normal dependency? If anything, wouldn't this be a <scope>test</scope> dependency?
Suggested change
| <type>pom</type> | |
| <scope>test</scope> |
Comment on lines
46
to
47
| <type>pom</type> | ||
| <scope>runtime</scope> |
There was a problem hiding this comment.
I don't think we need this type declaration, and this is probably a compile dependency, so we shouldn't need this scope declaration here.
Suggested change
| <type>pom</type> | |
| <scope>runtime</scope> |
Comment on lines
56
to
74
| // @Test | ||
| // fun `zip operator waits for both flows to emit`() = runTest { | ||
| // val stateFlow1 = MutableStateFlow(5) | ||
| // val stateFlow2 = MutableStateFlow("Hi") | ||
| // | ||
| // val zippedStateFlow = stateFlow1.zip(stateFlow2) { value1, value2 -> | ||
| // value1 to value2 | ||
| // } | ||
| // | ||
| // assertEquals(Pair(5, "Hi"), zippedStateFlow.first()) | ||
| // | ||
| // stateFlow1.value = 11 | ||
| // | ||
| // assertEquals(Pair(11, "Hi"), zippedStateFlow.first()) | ||
| // | ||
| // stateFlow2.value = "World" | ||
| // assertEquals(Pair(11, "World"), zippedStateFlow.first()) | ||
| // } | ||
|
|
There was a problem hiding this comment.
This test looks like it would be very promising, can we use this style instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests