Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 标注中文显示名 #546

Merged
merged 1 commit into from
Jul 25, 2024
Merged

ci: 标注中文显示名 #546

merged 1 commit into from
Jul 25, 2024

Conversation

YDX-2147483647
Copy link
Collaborator

name 用于 URL,不能有汉字,但 display label 可以。
#493 (comment)
https://github.com/adobe-fonts/source-han-serif/releases/tag/2.002R 就采用了这种方式。

  • 大部分上传改用 GitHub CLI,因为原来的 actions 似乎不支持指定 label,而且gh release upload更简单。
  • 中文显示名参考了网站
  • bithesis.pdf外都标注了。

Relates-to: #389

name 用于 URL,不能有汉字,但 display label 可以。
BITNP#493 (comment)
https://github.com/adobe-fonts/source-han-serif/releases/tag/2.002R 就采用了这种方式。

- 大部分上传改用 [GitHub CLI](https://cli.github.com/manual/gh_release_upload),因为原来的 actions 似乎不支持指定 label,而且`gh release upload`更简单。
- 中文显示名参考了[网站][wiki]。
- 除`bithesis.pdf`外都标注了。

Relates-to: BITNP#389

[wiki]: https://github.com/BITNP/BIThesis-wiki/blob/ee2c335682486359e31a25cbb11fc77d909a0a42/wiki/guide/preface.md#qbithesis-%E9%83%BD%E5%8C%85%E5%90%AB%E5%93%AA%E4%BA%9B%E6%A8%A1%E6%9D%BF
@YDX-2147483647 YDX-2147483647 marked this pull request as ready for review July 25, 2024 10:33
@fky2015
Copy link
Contributor

fky2015 commented Jul 25, 2024

挺好🙂。我之前一直想搞 label,但是当时发现 action 并不支持,甚至 GitHub 的 API 给的说明也非常少。

@fky2015
Copy link
Contributor

fky2015 commented Jul 25, 2024

不过还是建议先发个 preview 测试一下

@YDX-2147483647
Copy link
Collaborator Author

我单独试了gh release upload,而整体没法测试…… https://github.com/YDX-2147483647/BIThesis/actions/runs/10092483082

@YDX-2147483647
Copy link
Collaborator Author

那我合并进来试一下?

@fky2015 fky2015 added this pull request to the merge queue Jul 25, 2024
Merged via the queue into BITNP:main with commit cd01f88 Jul 25, 2024
3 checks passed
@YDX-2147483647 YDX-2147483647 deleted the label branch July 25, 2024 12:18
@YDX-2147483647
Copy link
Collaborator Author

https://github.com/BITNP/BIThesis/releases/tag/v3.7.10-alpha-1
能行,不过排序还是按文件名……怪不得思源宋体标了序号……

@fky2015
Copy link
Contributor

fky2015 commented Jul 25, 2024

挺好。BTW,下次可以发 v3.8.0 了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants