Remove renaming of older status files with _ suffix #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitha-p
requested review from
iamashwani-who,
vityagi and
mearvind
as code owners
|
|
||
|
|
||
| # It is possible in certain restore scenarios, where old setting files are present in the config folder | ||
| # When new VM is created with same extension, the seq# starts with 0 again. |
There was a problem hiding this comment.
probably better to explain how older setting files are retained in a new VM? I guess you are referring to the case when OS disk is created from a restore point or a snaphost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older WALA code had the logic to read the status file with highest sequence number. So VMSnapshotLinux extension would rename all other seq# files with _status suffix. But current WALA code reads the status of the currently executing sequence number. Renaming the status files are not needed. Guest agent has logic only to clear .status files not the ones with _status suffix. This means, older files can pile up in the VM as they don't get cleaned up.