Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update - Microsoft.Management missing from Subscription during Initialize #871

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

SebastianClaesson
Copy link
Contributor

Overview/Summary

  • Added Microsoft.Management Resource Provider to the prerequisites list.
  • Added to FAQ if Azure Mangement groups are not populated correctly.
  • Added new log message 'Initialize-AzOpsEnvironment.ManagementGroup.InsufficientPermissions'
  • Added logic to match if the error is due to insufficient permissions to register the Microsoft.Management resource provider.

I'm a bit unsure of how you like to have the catch logic & message(s), as it's maybe not such a clean fix and can be improved.
Please come with any feedback of suggestions and I'll happily implement them!

This PR fixes/adds/changes/removes

  1. RP Microsoft.Management missing from Subscription during Initialize #863

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers
Copy link
Member

Jefajers commented Apr 2, 2024

@SebastianClaesson, thanks for this contribution. I have made slight wording changes and a tradeoff in regards to the error message output by combining the current "simple" message and "logic" but always appending the full error message.

What do you think?

@Jefajers Jefajers changed the title PR - Microsoft.Management missing from Subscription during Initialize Update - Microsoft.Management missing from Subscription during Initialize Apr 2, 2024
@Jefajers Jefajers added this to the v2.6.1 milestone Apr 2, 2024
@Jefajers Jefajers added enhancement New feature or request wiki-doc Improvements or additions to documentation labels Apr 2, 2024
Changing from "Registered" to "Register".
@SebastianClaesson
Copy link
Contributor Author

Thanks! Looks really good!
I've changed from "Registered" to "Register" in prerequisties.

Copy link
Member

@Jefajers Jefajers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@Jefajers Jefajers merged commit 02c19f0 into Azure:main Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wiki-doc Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RP Microsoft.Management missing from Subscription during Initialize
2 participants