C++ Rewrite #74
Merged
C++ Rewrite #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pybind11 cannot directly store fundamental types so a custom class is required to wrap them for storage.
The template now only takes the tag and the base class is deduced in the class. This allows looking up the template based only on the tag.
This makes it easier to pass the wrappers to python
There is nothing in the class yet
This is needed for GCC but MSVC doesn't seem to care
The package now has a normal __init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is now entirely in C++ using Pybind11 to expose a Python API.
This should make it easier to extend.
I was hitting some of the limitations of Cython.
This also changes the API a little.
Custom exceptions have been removed.
Loading functions are renamed to
read_nbt,read_nbt_arrayandread_snbt