Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(a3p): migrate wallet and vaults related tests from a3p-proposals to the z:acceptance #10123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Jorge-Lopes
Copy link

@Jorge-Lopes Jorge-Lopes commented Sep 20, 2024

closes: Agoric/BytePitchPartnerEng#5
closes: Agoric/BytePitchPartnerEng#7
refs: #10049

Description

This PR is part of an ongoing effort to migrate some of the selected test cases from a3p-proposals to the z:acceptance test phase. More specifically:

  • test cases that are focused on invitation and payment behavior within the smart wallet
  • test cases that are focused on the actions that can be executed on vaults

Note: At the issues mentioned under "closes", we list the specific proposals of the selected test cases.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

One commit included in this PR fixes a small typo on a3p-integration/proposals/README.md

Testing Considerations

The new test files included in this PR are invoked through test.sh, so no changes to the current testing workflow are necessary.

However, as pointed out by @dckc in this comment, using waitForBlock() can lead to unexpected behavior. To address this, we plan to update the z:acceptance tests to mitigate this issue.

As a solution, we propose extending the @agoric/synthetic-chain package to export a method like makeRetryUntilCondition or a similar function. This would provide a more reliable alternative to waitForBlock().

Additionally, there is already an test-vaults.mts file that test operations related to changes on auctions parameters.
To avoid confusion with vaults.test due to the similarity in names, I propose renaming this file to auction.test and expanding its scope to cover all auction-related tests.

Upgrade Considerations

n/a

@Jorge-Lopes Jorge-Lopes changed the title Jorge/acceptance migration wallet test(a3p): migrate wallet and vaults related tests from a3p-proposals to the z:acceptance Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate existing vaults related tests to z:acceptance migrate existing wallet related tests to z:acceptance
2 participants