Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add new rowTopOffsetRenderType grid option to use "transform" #1050

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Aug 23, 2024

  • related to issue Fix for CSS Rendering Issue at large row counts #1044, provide a new grid option to allow the possibility to use top offset CSS style via transform instead of top to fix some UI rendering issue on large dataset

    • for example each .slick-row have a top offset to represent which which row it is, let say our rowHeight is 25px, then the 2nd row typically has a CSS style of top: 50px, the 3rd row has top: 75px, and so on... this new grid option would use transform: translateY(25px) instead, there's benefit in doing this as shown in the article below
  • this might improve perf as well as per this article: Why Moving Elements With Translate() Is Better Than Pos:abs Top/left

  • we could possibly make this the default in our next major release (if it ever happen) but for now we can at least provide it as a new grid option. I also tested this with the Example Grouping (ESM) demo

@ghiscoding ghiscoding changed the title feat: add new rowTopOffsetRenderType grid option to use "transform" perf: add new rowTopOffsetRenderType grid option to use "transform" Aug 23, 2024
@ghiscoding ghiscoding merged commit 7b7ff83 into master Aug 23, 2024
2 checks passed
@ghiscoding ghiscoding deleted the feat/row-top-offset-style-type branch August 23, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant