fix: recalculate would not reset the scores

2mal3 · Aug 12, 2024 · 7c109e7 · 7c109e7
1 parent c443507
commit 7c109e7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/data/adco/functions/recalculate.mcfunction b/src/data/adco/functions/recalculate.mcfunction
@@ -17,8 +17,11 @@ advancement adco:first_join {
     }
 }
 
+scoreboard players reset * adco.score
 
 execute as @a run function adco:recalculate_player:
+    scoreboard players reset @s adco.score
+
     vanilla = ctx.inject(Vanilla)
     vanilla_advancements = vanilla.releases["1.21"].data.advancements
     for name, advancement in vanilla_advancements.items():

diff --git a/src/data/adco/functions/reset.mcfunction b/src/data/adco/functions/reset.mcfunction
@@ -1,10 +1,7 @@
 
 advancement revoke @a everything
 
-scoreboard objectives remove adco.score
-scoreboard objectives add adco.score dummy
-scoreboard objectives setdisplay list adco.score
-scoreboard objectives modify adco.score rendertype integer
+scoreboard players reset * adco.score
 
 tellraw @s:
     text: "Reset all Advancements for all online players"