$targetfile in puppetserver::config::bootstrap doesn't respect puppetserver 5.1.x

[Phil-Friderici]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: puppet-agent-5.3.4-1.el7.x86_64 & puppetserver-5.1.5-1.el7.noarch
• Ruby: 2.0.0
• Distribution: CentOS Linux release 7.4.1708 (Core)
• Module version: 3.0.0

How to reproduce (e.g Puppet code you use)

use puppetserver 5.1.5

What are you seeing

$targetfile in puppetserver::config::bootstrap is set to '/etc/puppetlabs/puppetserver/bootstrap.cfg' in dependency of the puppet agent version.

What behaviour did you expect instead

puppetserver 5.1.5 is using '/etc/puppetlabs/puppetserver/services.d/ca.cfg' instead.
$targetfile should be choosen by dependency of the installed puppetserver version not the agent version.

Output log

no output, functionality is silently ignored when the file isn't existing

Any additional information you'd like to impart

workaround: create a symlink pointing to the new location.

The puppet agent version number is not conclusive to set puppetserver details.
If we don't have a fact for puppetserver version, $targetfile should become a parameter with the current default values. This way you could override the (now) outdated defaults.

[ghoneycutt]

Thank you @Phil-Friderici for reporting this! Could you send a pull request to address the issue?

[Phil-Friderici]

here we go #54

[jardleex]

We also see this issue with:

• Puppet: puppet-agent-1.10.10-1xenial & puppetserver-2.8.1-1puppetlabs1

Here the path also should be '/etc/puppetlabs/puppetserver/services.d/ca.cfg'.
We're running this module on tag 2.1.0.

[Phil-Friderici]

@jardleex until this is fixed, you can use a symlink as workaround.

[jardleex]

Thanks for the hint. Did it this way right away, works very well.

file { 'symlink_bootstrap_cfg':
        ensure  => link,
        path    => '/etc/puppetlabs/puppetserver/bootstrap.cfg',
        target  => '/etc/puppetlabs/puppetserver/services.d/ca.cfg',
        require => Package['puppetserver'],
      }