Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary state object generation #15

Open
hurelhuyag opened this issue Mar 26, 2021 · 1 comment
Open

Unnecessary state object generation #15

hurelhuyag opened this issue Mar 26, 2021 · 1 comment
Assignees

Comments

@hurelhuyag
Copy link
Contributor

I just tried to generate PetClinic project again with latest xoom 1.5.3-SNAPSHOT version and I found this. In this example, PetEntity::register method constructing new PetState object and passing it to PetRegistered event and PetRegistered event object deconstructing it. Instead, PetEntity can just pass values directly to PetRegistered event.
Screenshot from 2021-03-26 10-37-17

@VaughnVernon
Copy link
Contributor

Thanks @hurelhuyag. I discussed this with @danilo-ambrosio and we decided for now we will keep it this way. We will likely change as you suggested, but for now it is lower priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants