-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cant pass extensionId validation #418
Comments
This still does not work. I created a fork that relies on the id in the manifest.json, and ignores the provided id. |
For manifest v3 the ID is required in diff --git a/node_modules/semantic-release-firefox-add-on/src/constants.js b/node_modules/semantic-release-firefox-add-on/src/constants.js
index c5dea36..2e34ade 100644
--- a/node_modules/semantic-release-firefox-add-on/src/constants.js
+++ b/node_modules/semantic-release-firefox-add-on/src/constants.js
@@ -11,8 +11,6 @@ const defaultOptions = {
}
const requiredOptions = {
- extensionId:
- 'Omitting this would create a new extension instead of a new version.',
targetXpi:
'Omitting this would leave the xpi file unnamed when it is returned from mozilla.',
}
diff --git a/node_modules/semantic-release-firefox-add-on/src/publish.js b/node_modules/semantic-release-firefox-add-on/src/publish.js
index ad0f63d..6c3ce35 100644
--- a/node_modules/semantic-release-firefox-add-on/src/publish.js
+++ b/node_modules/semantic-release-firefox-add-on/src/publish.js
@@ -16,7 +16,6 @@ const publish = async options => {
// the console which will lead to the validation page which should contain
// detailed reasons why the extension was rejected
const {
- extensionId,
artifactsDir,
channel,
sourceDir,
@@ -46,7 +45,6 @@ const publish = async options => {
apiSecret: FIREFOX_SECRET_KEY,
artifactsDir,
channel,
- id: extensionId,
sourceDir,
},
{ signAddon }, |
Thank you for this ! This got me unblocked. Hopefully a fix for this can be implemented soon |
Hi, thanks for the package, i have some issues with
extensionId
:I've tried to use the next value, as specified in mine manifest.json:
but received an error:
As I understood it is related to web-ext issue where the suggested solution is to omit
extensionId
value.However in this case I cant pass verifyConditions step.
Can I run webext without extensionId?
Desktop (please complete the following information):
Additional context
I need gecko.id in the manifest to access storage.sync feature.
The text was updated successfully, but these errors were encountered: