Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Ledger connect-kit loader with a direct dependency #716

Open
lukasz-zimnoch opened this issue Dec 22, 2023 · 0 comments
Open

Replace Ledger connect-kit loader with a direct dependency #716

lukasz-zimnoch opened this issue Dec 22, 2023 · 0 comments
Assignees
@manumonti
Labels
💎 components

Comments

@lukasz-zimnoch
Copy link
Member

Concerning the recent Ledger exploit, the dashboard should no longer use @ledgerhq/connect-kit-loader to dynamically load @ledgerhq/connect-kit from CDN. As per LedgerHQ/connect-kit#30 (comment), the loader library is now deprecated and should be replaced with a direct dependency to @ledgerhq/connect-kit in version >= 1.1.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manumonti manumonti

Labels
💎 components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasz-zimnoch @manumonti