-
Notifications
You must be signed in to change notification settings - Fork 1
/
Noah-TODOs.txt
257 lines (256 loc) · 38.9 KB
/
Noah-TODOs.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
Searching 50 files for "docstring" (regex, case sensitive)
C:\Users\morga\Documents\Software Engineering\Settler-Project\test.txt:
80 ================================== FAILURES ===================================
81 ____________________________ [pylint] docs\conf.py ____________________________
82: C: 1, 0: Missing module docstring (missing-module-docstring)
83 W: 12, 0: Redefining built-in 'copyright' (redefined-builtin)
84 C: 11, 0: Constant name "project" doesn't conform to UPPER_CASE naming style (invalid-name)
..
94
95 ___________________________ [pylint] src\action.py ____________________________
96: C: 1, 0: Missing module docstring (missing-module-docstring)
97 E: 1, 0: Unable to import 'trade' (import-error)
98 E: 2, 0: Unable to import 'building' (import-error)
99 E: 3, 0: Unable to import 'resource_' (import-error)
100: C: 5, 0: Missing class docstring (missing-class-docstring)
101: C: 9, 4: Missing function or method docstring (missing-function-docstring)
102 R: 5, 0: Too few public methods (1/2) (too-few-public-methods)
103: C: 12, 0: Missing class docstring (missing-class-docstring)
104 R: 12, 0: Too few public methods (1/2) (too-few-public-methods)
105: C: 41, 0: Missing class docstring (missing-class-docstring)
106 R: 41, 0: Too few public methods (1/2) (too-few-public-methods)
107: C: 71, 0: Missing class docstring (missing-class-docstring)
108 R: 71, 0: Too few public methods (1/2) (too-few-public-methods)
109: C: 98, 0: Missing class docstring (missing-class-docstring)
110 W:105, 8: Unused variable 'trade' (unused-variable)
111 R: 98, 0: Too few public methods (1/2) (too-few-public-methods)
...
127 C:154, 0: Trailing newlines (trailing-newlines)
128 W:110,51: TODO doesn't work (fixme)
129: C: 1, 0: Missing module docstring (missing-module-docstring)
130 E: 1, 0: Unable to import 'action' (import-error)
131 W: 1, 0: Wildcard import action (wildcard-import)
132 W: 3, 0: String statement has no effect (pointless-string-statement)
133: C: 65, 0: Missing class docstring (missing-class-docstring)
134 R: 65, 0: Too many instance attributes (12/7) (too-many-instance-attributes)
135 E: 71,61: Undefined variable 'Resource' (undefined-variable)
136 C: 71,77: Comparison 'resource.name() == None' should be 'resource.name() is None' (singleton-comparison)
137: C: 81, 4: Missing function or method docstring (missing-function-docstring)
138: C: 88, 4: Missing function or method docstring (missing-function-docstring)
139 E:112,25: Undefined variable 'BuildSettlementAction' (undefined-variable)
140 E:122,25: Undefined variable 'UpgradeSettlementAction' (undefined-variable)
141 E:132,25: Undefined variable 'BuildRoadAction' (undefined-variable)
142 E:142,25: Undefined variable 'TradeAction' (undefined-variable)
143: C:148, 4: Missing function or method docstring (missing-function-docstring)
144 E:149,15: Undefined variable 'random' (undefined-variable)
145 ______________________________ pycodestyle-check ______________________________
...
196 W: 12,31: TODO are we using ports? (fixme)
197 W: 15,31: TODO unsure how roads work in implementation (fixme)
198: C: 1, 0: Missing module docstring (missing-module-docstring)
199: C: 1, 0: Missing class docstring (missing-class-docstring)
200: C: 9, 4: Missing function or method docstring (missing-function-docstring)
201: C: 12, 4: Missing function or method docstring (missing-function-docstring)
202: C: 15, 4: Missing function or method docstring (missing-function-docstring)
203: C: 18, 4: Missing function or method docstring (missing-function-docstring)
204: C: 21, 4: Missing function or method docstring (missing-function-docstring)
205 ______________________________ pycodestyle-check ______________________________
206 C:\Users\morga\Documents\Software Engineering\Settler-Project\src\board.py:9:30: E261 at least two spaces before inline comment
...
245 C:315, 0: Trailing whitespace (trailing-whitespace)
246 C:373, 0: Trailing newlines (trailing-newlines)
247: C: 67, 0: Missing class docstring (missing-class-docstring)
248: C:371, 4: Missing function or method docstring (missing-function-docstring)
249 R: 1, 0: Similar lines in 2 files
250 ==src.main:[59:173]
...
864 W:444, 9: TODO check if restart is true. if so re-initialize all values to there start values, else maintain. (fixme)
865 W:710,42: TODO add to MainGame state (fixme)
866: C: 1, 0: Missing module docstring (missing-module-docstring)
867 E: 32,66: Module 'pygame' has no 'DOUBLEBUF' member (no-member)
868 C: 41, 0: Constant name "current_turn_number" doesn't conform to UPPER_CASE naming style (invalid-name)
869: C:187, 0: Missing class docstring (missing-class-docstring)
870 R:187, 0: Too many instance attributes (8/7) (too-many-instance-attributes)
871: C:199, 4: Missing function or method docstring (missing-function-docstring)
872 E:201,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
873 E:215,29: Module 'pygame' has no 'KEYDOWN' member (no-member)
...
875 E:224,34: Module 'pygame' has no 'K_BACKSPACE' member (no-member)
876 R:199, 4: Too many branches (14/12) (too-many-branches)
877: C:229, 4: Missing function or method docstring (missing-function-docstring)
878 C:231, 8: Variable name "WELCOME_FONT" doesn't conform to snake_case naming style (invalid-name)
879 C:232, 8: Variable name "WORD_FONT" doesn't conform to snake_case naming style (invalid-name)
880: C:260, 4: Missing function or method docstring (missing-function-docstring)
881: C:262, 4: Missing function or method docstring (missing-function-docstring)
882: C:265, 0: Missing class docstring (missing-class-docstring)
883 R:265, 0: Too many instance attributes (11/7) (too-many-instance-attributes)
884: C:280, 4: Missing function or method docstring (missing-function-docstring)
885 E:283,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
886 R:286,24: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
...
891 E:311,32: Module 'pygame' has no 'K_SPACE' member (no-member)
892 R:280, 4: Too many branches (15/12) (too-many-branches)
893: C:335, 4: Missing function or method docstring (missing-function-docstring)
894 R:335, 4: Too many local variables (21/15) (too-many-locals)
895 C:337, 8: Variable name "WORD_FONT" doesn't conform to snake_case naming style (invalid-name)
896 E:373,72: Module 'pygame' has no 'SRCALPHA' member (no-member)
897 E:375,63: Module 'pygame' has no 'BLEND_RGBA_MULT' member (no-member)
898: C:389, 4: Missing function or method docstring (missing-function-docstring)
899: C:404, 4: Missing function or method docstring (missing-function-docstring)
900: C:406, 4: Missing function or method docstring (missing-function-docstring)
901: C:409, 4: Missing function or method docstring (missing-function-docstring)
902: C:442, 0: Missing class docstring (missing-class-docstring)
903 R:442, 0: Too many instance attributes (15/7) (too-many-instance-attributes)
904: C:461, 4: Missing function or method docstring (missing-function-docstring)
905 E:463,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
906 E:487,31: Module 'pygame' has no 'KEYDOWN' member (no-member)
...
914 W:570,33: Using possibly undefined loop variable 'settlement' (undefined-loop-variable)
915 E:571,57: Module 'pygame' has no 'BLEND_RGBA_MULT' member (no-member)
916: C:579, 4: Missing function or method docstring (missing-function-docstring)
917: C:611, 4: Missing function or method docstring (missing-function-docstring)
918 R:611, 4: Too many local variables (19/15) (too-many-locals)
919 C:637, 8: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
920 C:645, 8: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
921: C:669, 4: Missing function or method docstring (missing-function-docstring)
922: C:710, 4: Missing function or method docstring (missing-function-docstring)
923 R:710, 4: Too many local variables (16/15) (too-many-locals)
924 R:710, 4: Too many statements (57/50) (too-many-statements)
925: C:777, 4: Missing function or method docstring (missing-function-docstring)
926: C:779, 4: Missing function or method docstring (missing-function-docstring)
927: C:782, 0: Missing class docstring (missing-class-docstring)
928: C:788, 4: Missing function or method docstring (missing-function-docstring)
929 E:790,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
930: C:794, 4: Missing function or method docstring (missing-function-docstring)
931: C:822, 4: Missing function or method docstring (missing-function-docstring)
932: C:824, 4: Missing function or method docstring (missing-function-docstring)
933: C:827, 0: Missing class docstring (missing-class-docstring)
934: C:833, 4: Missing function or method docstring (missing-function-docstring)
935 W:837,20: Redefining built-in 'id' (redefined-builtin)
936 E:836,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
937 C:837,20: Variable name "id" doesn't conform to snake_case naming style (invalid-name)
938 R:834, 8: Too many nested blocks (6/5) (too-many-nested-blocks)
939: C:847, 4: Missing function or method docstring (missing-function-docstring)
940: C:850, 4: Missing function or method docstring (missing-function-docstring)
941: C:852, 4: Missing function or method docstring (missing-function-docstring)
942: C:855, 0: Missing class docstring (missing-class-docstring)
943 R:855, 0: Too many instance attributes (8/7) (too-many-instance-attributes)
944: C:867, 4: Missing function or method docstring (missing-function-docstring)
945 E:869,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
946: C:890, 4: Missing function or method docstring (missing-function-docstring)
947 C:908, 8: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
948: C:949, 4: Missing function or method docstring (missing-function-docstring)
949: C:957, 4: Missing function or method docstring (missing-function-docstring)
950: C:959, 4: Missing function or method docstring (missing-function-docstring)
951: C:962, 0: Missing class docstring (missing-class-docstring)
952: C:971, 4: Missing function or method docstring (missing-function-docstring)
953 E:974,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
954 W:975,32: Unused variable 'resource' (unused-variable)
955: C:1006, 4: Missing function or method docstring (missing-function-docstring)
956 W:1036,39: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
957: C:1040, 4: Missing function or method docstring (missing-function-docstring)
958: C:1042, 4: Missing function or method docstring (missing-function-docstring)
959: C:1045, 0: Missing class docstring (missing-class-docstring)
960: C:1055, 4: Missing function or method docstring (missing-function-docstring)
961 E:1058,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
962 W:1059,27: Unused variable 'image' (unused-variable)
963: C:1067, 4: Missing function or method docstring (missing-function-docstring)
964 W:1075,41: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
965: C:1093, 4: Missing function or method docstring (missing-function-docstring)
966: C:1095, 4: Missing function or method docstring (missing-function-docstring)
967: C:1099, 0: Missing class docstring (missing-class-docstring)
968: C:1107, 4: Missing function or method docstring (missing-function-docstring)
969 E:1110,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
970 R:1108, 8: Too many nested blocks (6/5) (too-many-nested-blocks)
971: C:1126, 4: Missing function or method docstring (missing-function-docstring)
972: C:1130, 4: Missing function or method docstring (missing-function-docstring)
973 R:1131, 8: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
974: C:1153, 4: Missing function or method docstring (missing-function-docstring)
975: C:1155, 4: Missing function or method docstring (missing-function-docstring)
976: C:1158, 0: Missing class docstring (missing-class-docstring)
977: C:1168, 4: Missing function or method docstring (missing-function-docstring)
978 E:1170,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
979 C:1176,31: Comparison 'self.node1 == None' should be 'self.node1 is None' (singleton-comparison)
980 R:1169, 8: Too many nested blocks (7/5) (too-many-nested-blocks)
981: C:1191, 4: Missing function or method docstring (missing-function-docstring)
982: C:1198, 4: Missing function or method docstring (missing-function-docstring)
983: C:1213, 4: Missing function or method docstring (missing-function-docstring)
984: C:1216, 4: Missing function or method docstring (missing-function-docstring)
985: C:1218, 4: Missing function or method docstring (missing-function-docstring)
986: C:1222, 0: Missing class docstring (missing-class-docstring)
987 R:1222, 0: Too many instance attributes (9/7) (too-many-instance-attributes)
988: C:1235, 4: Missing function or method docstring (missing-function-docstring)
989: C:1258, 4: Missing function or method docstring (missing-function-docstring)
990 E:1261,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
991: C:1271, 4: Missing function or method docstring (missing-function-docstring)
992: C:1273, 4: Missing function or method docstring (missing-function-docstring)
993: C:1276, 0: Missing class docstring (missing-class-docstring)
994: C:1286, 4: Missing function or method docstring (missing-function-docstring)
995: C:1298, 4: Missing function or method docstring (missing-function-docstring)
996 W:1302,44: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
997: C:1316, 4: Missing function or method docstring (missing-function-docstring)
998: C:1335, 4: Missing function or method docstring (missing-function-docstring)
999 E:1338,27: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
1000: C:1345, 4: Missing function or method docstring (missing-function-docstring)
1001: C:1347, 4: Missing function or method docstring (missing-function-docstring)
1002: C:1350, 0: Missing class docstring (missing-class-docstring)
1003 R:1350, 0: Too many instance attributes (13/7) (too-many-instance-attributes)
1004: C:1368, 4: Missing function or method docstring (missing-function-docstring)
1005: C:1389, 4: Missing function or method docstring (missing-function-docstring)
1006 E:1392,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
1007 E:1400,42: No value for argument 'quantity' in constructor call (no-value-for-parameter)
1008: C:1402, 4: Missing function or method docstring (missing-function-docstring)
1009: C:1404, 4: Missing function or method docstring (missing-function-docstring)
1010: C:1407, 0: Missing class docstring (missing-class-docstring)
1011 R:1407, 0: Too many instance attributes (9/7) (too-many-instance-attributes)
1012: C:1421, 4: Missing function or method docstring (missing-function-docstring)
1013: C:1430, 4: Missing function or method docstring (missing-function-docstring)
1014 E:1432,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
1015: C:1439, 4: Missing function or method docstring (missing-function-docstring)
1016: C:1441, 4: Missing function or method docstring (missing-function-docstring)
1017: C:1445, 0: Missing class docstring (missing-class-docstring)
1018: C:1459, 4: Missing function or method docstring (missing-function-docstring)
1019 E:1459, 4: An attribute defined in src.main_refactored line 1457 hides this method (method-hidden)
1020 R:1463,16: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
1021 R:1471,16: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
1022 R:1459, 4: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
1023: C:1477, 4: Missing function or method docstring (missing-function-docstring)
1024: C:1490, 4: Missing function or method docstring (missing-function-docstring)
1025: C:1492, 4: Missing function or method docstring (missing-function-docstring)
1026: C:1495, 0: Missing class docstring (missing-class-docstring)
1027: C:1503, 4: Missing function or method docstring (missing-function-docstring)
1028 E:1506,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
1029: C:1510, 4: Missing function or method docstring (missing-function-docstring)
1030: C:1513, 4: Missing function or method docstring (missing-function-docstring)
1031: C:1515, 4: Missing function or method docstring (missing-function-docstring)
1032: C:1519, 0: Missing class docstring (missing-class-docstring)
1033: C:1527, 4: Missing function or method docstring (missing-function-docstring)
1034 C:1530, 8: Variable name "y" doesn't conform to snake_case naming style (invalid-name)
1035 C:1534,12: Variable name "y" doesn't conform to snake_case naming style (invalid-name)
1036: C:1543, 4: Missing function or method docstring (missing-function-docstring)
1037 E:1545,29: Module 'pygame' has no 'MOUSEBUTTONDOWN' member (no-member)
1038: C:1549, 4: Missing function or method docstring (missing-function-docstring)
1039: C:1551, 4: Missing function or method docstring (missing-function-docstring)
1040: C:1557, 0: Missing function or method docstring (missing-function-docstring)
1041 E:1568,29: Module 'pygame' has no 'QUIT' member (no-member)
1042 W:1559, 4: Unused variable 'player_turn_index' (unused-variable)
....
1646 W:167, 9: TODO implement get_length() in Road class (fixme)
1647 C: 46,77: Comparison 'resource.name() == None' should be 'resource.name() is None' (singleton-comparison)
1648: C:148, 4: Missing function or method docstring (missing-function-docstring)
1649 W: 5, 0: Unused Settlement imported from src.building (unused-import)
1650 W: 5, 0: Unused City imported from src.building (unused-import)
....
1698 C: 61, 0: Trailing whitespace (trailing-whitespace)
1699 C:391, 0: Trailing whitespace (trailing-whitespace)
1700: C: 62, 4: Missing function or method docstring (missing-function-docstring)
1701 ______________________________ pycodestyle-check ______________________________
1702 C:\Users\morga\Documents\Software Engineering\Settler-Project\src\tiles.py:12:45: W291 trailing whitespace
....
1751 ________________________ [pylint] tests\player_test.py ________________________
1752 C: 91,66: Trailing whitespace (trailing-whitespace)
1753: C: 36, 0: Missing function or method docstring (missing-function-docstring)
1754 E: 43, 4: Undefined variable 'pdb' (undefined-variable)
1755: C: 88, 0: Missing function or method docstring (missing-function-docstring)
1756 ______________________________ pycodestyle-check ______________________________
1757 C:\Users\morga\Documents\Software Engineering\Settler-Project\tests\player_test.py:26:80: E501 line too long (84 > 79 characters)