Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use with ruby 2.4+ #108

Closed
jcoyne opened this issue Jun 7, 2018 · 0 comments
Closed

Can't use with ruby 2.4+ #108

jcoyne opened this issue Jun 7, 2018 · 0 comments
Assignees
@jcoyne
Labels
tech debt

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Jun 7, 2018

Because of the dependency on fakeweb. See chrisk/fakeweb#62. We should move to webmock.
jcoyne added a commit that referenced this issue Jun 7, 2018
@jcoyne
Now that we deploy on ruby 2.3.4, drop the 2.2 build.
da9fb68 
Note that we can't add 2.4+ due to #108
This was referenced Jun 7, 2018
Merged
Merged
jcoyne added a commit that referenced this issue Jun 8, 2018
@jcoyne
Switch from fakeweb to webmock
dc37fcb 
Fakeweb is no longer maintained (last release 2010) and doesn't support
ruby > 2.4+

Fixes #108
jcoyne added a commit that referenced this issue Jun 8, 2018
@jcoyne
Switch from fakeweb to webmock
e44b939 
Fakeweb is no longer maintained (last release 2010) and doesn't support
ruby > 2.4+

Fixes #108
@jcoyne jcoyne mentioned this issue Jun 8, 2018
Merged
@vivnwong vivnwong added the review label Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcoyne jcoyne

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcoyne @aaron-collier @vivnwong