Should we remove streamedAmountOf from Linear/Dynamic/Tranched interfaces? #856
Closed
andreivladbrg
started this conversation in
General
Replies: 3 comments
-
I've pushed a commit here b4a264d to help you understand better what I am referring to. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I don't have anything against this idea. It looks better to me. I find the streaming functions comment more suitable for |
Beta Was this translation helpful? Give feedback.
0 replies
-
Implemented in #864 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
After this PR #813, the only duplicated getter function that remains in the interfaces is
streamedAmountOf
. Its presence in the unique interface is due to the differing natspec comments between them:Now, we are simply overriding the function implemented in
SablierV2Lockup
:v2-core/src/SablierV2LockupLinear.sol
Line 128 in 1b2ee6d
I was considering whether it would be better to remove the function from the Linear/Dynamic/Tranched interfaces and move the natspec to the bespoke contract at
_calculateStreamedAmount
?Example Linear
What do you guys say? @PaulRBerg @smol-ninja
Beta Was this translation helpful? Give feedback.
All reactions