-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top Bar missing after opening video in fullscreen on maximised client [Bug] #160
Comments
Hey man, thank u, for me it worked. In the piece of code inside awesome/ui/panels/top-panel/init.lua that you described, I change the piece of code that said: local function remove_top_panel(c) to: local function remove_top_panel(c) And now the top-panel appears when I get out of fullscreen, thanks, It's been something that bodered me for days |
Other way to fix this, would be adding panel upon fullscrean/maximized window going out of focus, which should be what desired (idk about multihead). Only change that needs to be made, is changing signal to
|
|
Describe the bug
When you open a video in fullscreen on a maximised client and then exit out of full screen the top bar is missing
Expected behavior
the top bar should be shown again after leaving fullscreen mode
Screenshots
If applicable, add screenshots to help explain your problem.
Distro (please complete the following information):
i am on manjaro, but the bug should probably happen on all distros
Additional context
The bug happens because in awesome/ui/panels/top-panel/init.lua the function remove_top_panel() hides the top panel when either the client is maximised or in fullscreen.
But the function is only executed when the client is put in fullscreen
there are 2 ways of fixing this:
below the line with fullscreen
from the function
this depends on how u want the ui to behave, but i believe the intended way would be option 2)
P.S.:
in the same location there is a very similar function called
add_top_panel()
which also checks for both c.maximized and c.fullscreen. This might cause a bug aswell, but since I don't know whatclient.connect_signal("request::unmanage", add_top_panel)
does, I am not able to test this assumptionThe text was updated successfully, but these errors were encountered: