Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural on tests/examples and other conventions #46

Closed
5 tasks done
jgvictores opened this issue Feb 3, 2018 · 16 comments
Closed
5 tasks done

Plural on tests/examples and other conventions #46

jgvictores opened this issue Feb 3, 2018 · 16 comments
Assignees
Labels
complexity: tedious Tarea tediosa que nadie quiere hacer horizontal

Comments

@jgvictores
Copy link
Member

jgvictores commented Feb 3, 2018

Singular or plural and other conventions:

  1. Derived from the constant example (yarp-ish) vs examples directory.
  2. @PeterBowman pointed out this also happens with cmake/template vs cmake/templates
  3. Also test(s)

Proposed ToDo:

@PeterBowman
Copy link
Member

+1 for plural.

@jgvictores
Copy link
Member Author

+1 for plural.

Yes, I think this is more intuitive.

@PeterBowman
Copy link
Member

Also, I started cleaning a bit the contents of cmake/, thus we may encounter subdirs such as:

In the future, YCM build modules could be moved into cmake/build-modules/. I borrowed this idea from the YCM repo.

jgvictores added a commit to roboticslab-uc3m/openrave-yarp-plugins that referenced this issue Feb 3, 2018
@PeterBowman
Copy link
Member

In the future, YCM build modules could be moved into cmake/build-modules/. I borrowed this idea from the YCM repo.

I'd suggest another name since .gitignore will probably mess up with anything that starts with build (proof). Perhaps... cmake/ycm-modules/, and also move IncludeUrl.cmake and YCMBootstrap.cmake in there.

@jgvictores
Copy link
Member Author

Updated description with test(s) from #41.

@PeterBowman
Copy link
Member

Decide on standard.

Perhaps we could go a bit further and outline the standard directory layout for most projects, that is, the tree structure of folders (libraries/, programs/, test()s/, etc.). Yeah, this is somehow reflected in project-generator, but might be best doing it in a more official way with a mention in developer-manual.

@jgvictores
Copy link
Member Author

(...) might be best doing it in a more official way with a mention in developer-manual.

LGTM! Some comments:

  1. Yes, I like the idea of a reference guide in developer-manual; hence, project-generator as an implementation that points to it.
  2. Take into account https://github.com/roboticslab-uc3m/project-generator/issues

jgvictores added a commit to roboticslab-uc3m/yarp-devices that referenced this issue Feb 8, 2018
jgvictores added a commit to roboticslab-uc3m/kinematics-dynamics that referenced this issue Feb 13, 2018
jgvictores added a commit to roboticslab-uc3m/kinematics-dynamics that referenced this issue Feb 13, 2018
PeterBowman added a commit to roboticslab-uc3m/color-debug that referenced this issue Feb 14, 2018
@jgvictores jgvictores changed the title Singular or plural and other conventions Plural on tests/examples and other conventions Feb 15, 2018
PeterBowman added a commit to roboticslab-uc3m/project-generator that referenced this issue Feb 20, 2018
@PeterBowman
Copy link
Member

Also: doc -> docs? I don't want to get too far...

@jgvictores
Copy link
Member Author

Not sure... I've always read doc as documentation rather than documents.
Perhaps laziness, as there is a considerable amount of links that would have to be updated across organizations.

@PeterBowman
Copy link
Member

Not sure about what feels better, see https://readthedocs.org/. I'd succumb to laziness for this one, though.

there is a considerable amount of links that would have to be updated across organizations.

I was about to prepare a TODO list, but there are so many repos with cmake/template/... +1 for a tedious label.

@jgvictores
Copy link
Member Author

+1 for a tedious label.

Totally agreed: Ref ((in Spanish, color is meaningful too))

@PeterBowman
Copy link
Member

Reminder: also apply plural rules in Doxyfile! >>REF<<

@jgvictores jgvictores added the complexity: tedious Tarea tediosa que nadie quiere hacer label Mar 2, 2018
@jgvictores
Copy link
Member Author

Reminder: also apply plural rules in Doxyfile! >>REF<<

Yup!

jgvictores added a commit to roboticslab-uc3m/tools that referenced this issue Mar 8, 2018
PeterBowman added a commit to roboticslab-uc3m/openrave-yarp-plugins that referenced this issue Mar 9, 2018
PeterBowman added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue Mar 13, 2018
PeterBowman added a commit to roboticslab-uc3m/kinematics-dynamics that referenced this issue Mar 15, 2018
PeterBowman added a commit to roboticslab-uc3m/openrave-yarp-plugins that referenced this issue Mar 15, 2018
PeterBowman added a commit to roboticslab-uc3m/color-debug that referenced this issue Mar 15, 2018
@PeterBowman
Copy link
Member

PeterBowman commented Mar 15, 2018

The following changes have been applied:

  • rename example/ to examples/
  • rename test/ to tests/
  • rename cmake/template/ to cmake/templates/
  • update doc/Doxyfile

Affected and processed repositories:

Affected and ignored repositories:

No more occurrences found.

@jgvictores
Copy link
Member Author

THANKS a lot for all of this!

@PeterBowman
Copy link
Member

Also: doc -> docs? I don't want to get too far...

Not sure... I've always read doc as documentation rather than documents.
Perhaps laziness, as there is a considerable amount of links that would have to be updated across organizations.

Just noticed that YCM has a docs directory (ref).

rsantos88 pushed a commit to roboticslab-uc3m/yarp-devices that referenced this issue Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: tedious Tarea tediosa que nadie quiere hacer horizontal
Projects
None yet
Development

No branches or pull requests

2 participants