Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicCartesianControl] needs improvements in movl #46

Closed
2 tasks
jgvictores opened this issue Jul 6, 2016 · 4 comments
Closed
2 tasks

[BasicCartesianControl] needs improvements in movl #46

jgvictores opened this issue Jul 6, 2016 · 4 comments
Labels

Comments

@jgvictores
Copy link
Member

jgvictores commented Jul 6, 2016

[BasicCartesianControl] needs improvements in movl.

  • Trajectories in simulation need gain and shouldn't need any. Trajectories on the real robot need more gain and are rather faulty.
  • Should be able to set velocity instead of duration.
@PeterBowman
Copy link
Member

These improvements could be handled by a new controller interface, see #105 (comment):

I was thinking about a new interface (inheritable by BasicCartesianControl and the like) for managing controller configuration during runtime. In fact, it would be nice to have the ability to select a different gain, tweak the maximum joint velocity and trajectory time (along the lines of #46), change the trajectory generator, enable RPC/streaming mode, or even choose the reference frame for input coordinates. Do you think it's feasible?

@PeterBowman PeterBowman added the blocked Do not focus on this issue until blocking issue is closed label Oct 28, 2017
@PeterBowman
Copy link
Member

We are going to dismiss the proposal quoted in my previous comment and implement new methods directly in the controller interface. Until that, this issue is blocked by #121.

@PeterBowman PeterBowman removed the blocked Do not focus on this issue until blocking issue is closed label Jan 19, 2018
@jgvictores
Copy link
Member Author

Related: #135

@PeterBowman
Copy link
Member

It's almost two years now and nothing has moved here. I guess this issue originated when the first implementation for BasicCartesianControl became available and still required testing. Conclusion:

  • The first subtask may be deemed invalid (either unclear or solved). I've been working with this controller on a real robot and didn't notice any particular issues with the controller gain. Also, I can set it to zero and still work on the simulator.

  • The second subtask has been moved to Make linear trajectories depend on velocity instead of time #157.

@PeterBowman PeterBowman closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants