Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some of the CSS styles #9

Open
A1Liu opened this issue Feb 19, 2023 · 1 comment
Open

Rename some of the CSS styles #9

A1Liu opened this issue Feb 19, 2023 · 1 comment

Comments

@A1Liu
Copy link
Collaborator

A1Liu commented Feb 19, 2023

The CSS styles in @robin/toolbox are not all named in useful ways. Ideally the class names should be based on the purpose of the style instead of what it is. I don't know enough about design systems to be able to name them in a way that makes sense. Eventually this will be fixed.

@karimsa
Copy link
Member

karimsa commented Feb 27, 2023

The use of the property in the name as opposed to purpose makes sense - it is the pattern that tailwind uses, idea being to focus on providing primitives and let the user do the styling bits. Otherwise, we will end up creating a component library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants