Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially remove internal filter_message_top_n #218

Open
maximusunc opened this issue Oct 10, 2023 · 1 comment
Open

Potentially remove internal filter_message_top_n #218

maximusunc opened this issue Oct 10, 2023 · 1 comment

Comments

@maximusunc
Copy link
Contributor

Maybe this is a bug somewhere in Aragorn, but sometimes the workflow is included in the call to aragorn_ranker. In that workflow is the filter_message_top_n operation, which isn't a valid operation and scorer throws a 422. I'm not sure why the workflow is included. We either need to remove this pseudo operation or find out why the workflow is being included in subservice queries.

@maximusunc
Copy link
Contributor Author

Never mind. I saw an error from scorer and then tried to pass the response through scorer myself, but the return message from Aragorn does include the workflow to show the user what workflow was run. Though that now makes me worried that some upstream service might do some TRAPI validation (they really should) and they would end up barfing on our response. So I'm going to double down on removing it as an internal pseudo workflow operation. We either need to remove it or get filter_message_top_n into the TRAPI spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant