Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing in-game settings for one account resets settings from other accounts #58

Open
Clover-Lindo opened this issue Mar 22, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Clover-Lindo
Copy link
Collaborator

When multiple accounts are running on the same window, each one creates a copy of the settings of all accounts. Meaning that changing the settings of one account won't affect the copies existing on other tabs.
Since these settings are shared in the local storage (or cookies? I don't remember), it means that validating the settings on one account will rollback any setting changed on other tabs.

Currently, the other solution to edit settings for multiple accounts on the same window is start only one account, change the settings, log out then restart with the second account etc.

@Clover-Lindo Clover-Lindo added the bug Something isn't working label Mar 22, 2020
@Clover-Lindo Clover-Lindo changed the title Changing in-game settings for one accounts resets settings from other accounts Changing in-game settings for one account resets settings from other accounts Mar 22, 2020
@Clover-Lindo
Copy link
Collaborator Author

Here's a copy of a description from an old Trello project for Lindo:

En multicompte sur une fenêtre (ou sur l'ensemble des fenêtre pour Lindo <1.1.6), l'ensemble des settings de tout les comptes est chargé dans chaque onglet. Changer les options d'un compte va mettre à jour les options de ce compte, et réécrire les options des autres à l'état dans lequel elles étaient au lancement de l'onglet.

Solutions :

  • Override les fonctions de gestion des settings pour stocker dans le Local Storage les settings de chaque compte à partir d'une clé différente (plutôt que de tout mettre sous la même clé)
  • Créer un event qui va reload les settings d'un onglet lors du changement des settings d'un autre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant