New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc_regulariser requires minus symbol? #2

Open

goodman1204 opened this issue Jun 1, 2020 · 1 comment

goodman1204 commented Jun 1, 2020

The the paper:"Disentangling by Factorising
motivate", tc_regulariser should have minus before it, but in the code, the minus symbol seems lost.

RuihongQiu commented Nov 16, 2020 •

edited

Loading

Because in Eq. (2), it's a objective function rather than a loss function. The sign needs to flip when optimizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment