Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Run() code from gocollector should be refactored (into submodule) #29

Open
wdoekes opened this issue May 12, 2017 · 0 comments
Open

The Run() code from gocollector should be refactored (into submodule) #29

wdoekes opened this issue May 12, 2017 · 0 comments
Labels
SpringCleaning

Comments

@wdoekes
Copy link
Member

wdoekes commented May 12, 2017

gocollect/gocollector/collectors.go

Line 67 in 8862313

func (c *Collectors) Run(key string) Collected {

  • The bits that are not gocollect specific should be moved to a separate (sub)process module.
  • They should get tests.
  • Most of this file applies: only the collector[%s] printf and NewCollected are gocollect-specific.
wdoekes added a commit that referenced this issue Jul 4, 2017
@wdoekes
cleanup: SpringCleaning. Split up into several modules.
67d81b8 
Closes #32.
Closes #34.
Touches #29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SpringCleaning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wdoekes