Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getHalfHaldaneSub might have issues for large number of relationships #95

Open
dczielinski opened this issue Sep 21, 2018 · 0 comments
Open

Comments

@dczielinski
Copy link
Collaborator

getHalfHaldaneSub tries to create an equivalence relationship to substitute out a rate constant algebraically based on First Law constraints. When many First Law constraints are present for an enzyme, these are provided by a list. For each element in the list, we get a list of rate constants. For each rate constant, we see if it has already been subbed out and if not we create an equivalence relationship for the first one. The potential issue is that having too many pre-existing relationships such that all rate constants have been previously substituted and no new rate constant relationships can be added. This is likely an extreme fringe case, but it may be possible to create safer behavior with quite a bit more complicated checking and storing of results from previous rounds (i.e. store all equivalence relationships, then solve at the very end for independent rate constant substitutions to use).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant