Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRatio assumes a particular reaction direction #93

Open
dczielinski opened this issue Sep 20, 2018 · 0 comments
Open

getRatio assumes a particular reaction direction #93

dczielinski opened this issue Sep 20, 2018 · 0 comments

Comments

@dczielinski
Copy link
Collaborator

The function getRatio returns the equilibrium constant of reactions that a particular metabolite is involved with. This is intended to be used to get the dissociation constant of activator or inhibitor reactions, but it just grabs the equilibrium constant of the reaction without regard to the direction of the reaction. Safer behavior would be to check the direction of the reaction so that a dissociation constants is always returned (as opposed to an association constant if the reaction is defined in the opposite direction as expected). Given the way that activator and inhibitor reactions are defined currently, this is not a practical issue, but could become an issue if we change the usage case of this function or how we define activation/inhibition reactions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant