Include articles with embedded videos

[br72]

Hi there. Thanks for all your work on this. I use it frequently to get articles in to my kindle.

I have noticed recently that more of my articles have embedded videos in them, and the program misses including those. I typically add those individually into my kindle by opening the webpage for the article and using a "Send to Kindle" bookmarklet I found on the web.

I am hoping you can adjust the code on your calibre plugin to allow me to include articles with embedded vidoes. I figured that it could be done without readability issues since the bookmarklet is able to render the webpage without issue.

I spent some time trying to figure out how to modify the code myself, but I know nothing about programming. After several hours of clodding about, I was able to determine only that contenttype would be video and the has_video response would equal 1.

[onlyhavecans]

Both my kindle and nook is e-paper so I would have no way to test if the imbedded videos work in the ebooks. Sorry.
If someone else is willing to develop, test, and maintain I will accept pull requests for this as an optional feature

[br72]

Thanks Bunny Man. My ebook is a kindle as well, and I have no interest in whether the videos work. I just want the articles that contain videos included with all the articles when the ebook is created. As it stands now, those articles are left out.

On Jul 25, 2014, at 1:26 AM, the Bunny Man notifications@github.com wrote:

Both my kindle and nook is e-paper so I would have no way to test if the imbedded videos work in the ebooks. Sorry.
If someone else is willing to develop, test, and maintain I will accept pull requests for this as an optional feature

—
Reply to this email directly or view it on GitHub.

[onlyhavecans]

Oh. When i get some time I will look at why they aren't also being grabbed. That's odd

[br72]

Thanks. I looked into it a little bit. It seems Pocket codes those as contentType = video and gives it a value for has_video = 1. I thought it would be non trivial to add a line or two of code to grab these, but I don't know anything about programming, so I leave it to people who know what they're doing.

As long as you're looking in to things, I found another oddity. If I begin reading an article I sent to pocket in my iphone, stop in the middle, leave it in my list (not archived) and then later fetch the articles on my list and send it to my kindle, that partially read article does not get included. It's not technically unread but it's not archived either.

Anyway, thanks for looking in to it.

On Jul 25, 2014, at 6:08 AM, the Bunny Man notifications@github.com wrote:

Oh. When i get some time I will look at why they aren't also being grabbed. That's odd

—
Reply to this email directly or view it on GitHub.