Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all the transactions and scripts to use prepare/execute and post-conditions #288

Open
joshuahannan opened this issue May 25, 2022 · 0 comments
Open

Update all the transactions and scripts to use prepare/execute and post-conditions #288

joshuahannan opened this issue May 25, 2022 · 0 comments
Assignees
@joshuahannan
Labels
documentation Improvements or additions to documentation Feedback MoSCoW - Should P-Medium SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Smart Contract Technical Debt

Comments

@joshuahannan
Copy link
Member

Issue To Be Solved

Many of the transactions in scripts to everything in the prepare block, which is against Cadence best practices
There are also opportunities to include post conditions in many of the transactions to ensure they executed properly

Suggest A Solution

  • Split all transactions into prepare/execute when possible
  • Add post conditions where possible
  • Add additional comments to scripts and transactions if they are not documented
@joshuahannan joshuahannan added documentation Improvements or additions to documentation Feedback MoSCoW - Should P-Medium Smart Contract Technical Debt SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board labels May 25, 2022
@joshuahannan joshuahannan self-assigned this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuahannan joshuahannan

Labels
documentation Improvements or additions to documentation Feedback MoSCoW - Should P-Medium SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Smart Contract Technical Debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuahannan