From 7825000008544971f041d0949f201eb64b8d06f2 Mon Sep 17 00:00:00 2001 From: Rabbit Date: Mon, 5 Aug 2024 14:43:04 +0800 Subject: [PATCH] fix: optimize transactions sorting (#2120) --- app/interactions/addresses/ckb_transactions.rb | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/app/interactions/addresses/ckb_transactions.rb b/app/interactions/addresses/ckb_transactions.rb index 2b21ceba0..dcba4cfe6 100644 --- a/app/interactions/addresses/ckb_transactions.rb +++ b/app/interactions/addresses/ckb_transactions.rb @@ -4,7 +4,7 @@ class CkbTransactions < ActiveInteraction::Base object :request, class: ActionDispatch::Request string :key, default: nil - string :sort, default: "ckb_transaction_id.desc" + string :sort, default: "time.desc" integer :page, default: 1 integer :page_size, default: CkbTransaction.default_per_page @@ -29,16 +29,10 @@ def execute private def account_books_ordering - sort_by, sort_order = sort.split(".", 2) - sort_by = - case sort_by - when "time" then "ckb_transactions.block_timestamp" - else "ckb_transactions.id" - end + sort_by = "ckb_transactions.block_timestamp" + _, sort_order = sort.split(".", 2) - if sort_order.nil? || !sort_order.match?(/^(asc|desc)$/i) - sort_order = "asc" - end + sort_order = "asc" unless sort_order&.match?(/^(asc|desc)$/i) [sort_by, sort_order] end