Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fonts #19

Open
tawrahim opened this issue Jun 5, 2016 · 12 comments
Open

Custom fonts #19

tawrahim opened this issue Jun 5, 2016 · 12 comments

Comments

@tawrahim
Copy link
Contributor

tawrahim commented Jun 5, 2016

Would it be possible to extend this library to allow developers to specify custom fonts in the tableView cell?

@neoneye
Copy link
Owner

neoneye commented Jun 5, 2016

Theming is not something I have spent time on. I think it should be possible to style things with UIAppearance, but there are probably obstacles. I ought to make an example of how to do it.

What do you think?

@tawrahim
Copy link
Contributor Author

tawrahim commented Jun 5, 2016

Hmm so am not exactly sure with UIAppearance.

I quickly tried this
UITableViewCell.appearance().textLabel?.font = UIFont(name: "Exo2.0-Regular", size: 15.0) in the viewDidLoad method and it did not work. I was looking at the code and notice at round line 34 you set the font style. I think it would be great if we can make that settable.

@neoneye
Copy link
Owner

neoneye commented Jun 5, 2016

Yes, the init code currently sets the fonts. It doesn't have to be like this, but I'm not sure what is best practice with theming. Maybe it's UIAppearance or a new swift approach. Maybe it would be better to extend the CellModel with theming properties.

@tawrahim
Copy link
Contributor Author

tawrahim commented Jun 5, 2016

I think extending the CellModel makes the most sense and looks very clean to me.

@neoneye
Copy link
Owner

neoneye commented Jun 5, 2016

Awesome @tawrahim, I would love to see a proposal from you.

@tawrahim
Copy link
Contributor Author

tawrahim commented Jun 6, 2016

Haha great I would see if I can squeeze in sometime to work on it.
I also think if it is easier for you to just extend it, It would be awesome since you are most familiar with the code 😄

@neoneye
Copy link
Owner

neoneye commented Jun 6, 2016

Your cocoapod contributions are much appreciated. Never give up.

When I'm not working, then I'm coding on various iOS projects. There is too little time in this world.

@tawrahim
Copy link
Contributor Author

tawrahim commented Jun 6, 2016

Ok let me see what I can do since I'm also heavily involved with this project to get v2.0 released. Lets see what happens.

@neoneye
Copy link
Owner

neoneye commented Jun 6, 2016

Your project looks cool. Is it pure swift?

@tawrahim
Copy link
Contributor Author

tawrahim commented Jun 6, 2016

Yeah it is! And we are using your amazing library for some of our view
controllers.

@neoneye
Copy link
Owner

neoneye commented Jun 6, 2016

There is a local phenomenon here in Denmark, it's gomore. I don't know if it's big outside europa. It seems related 👍

@tawrahim
Copy link
Contributor Author

tawrahim commented Jun 8, 2016

It is a little bit different but we both embody the spirit of the sharing economy 🔹
In any case I would try and see if I can make some progress with this issue this weekend. However if you do get it to work on it first that would be even cooler 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants